Tidying

src/freedombone-utils-onion

 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+function onion_update {
+    # update so that new onion services appear
+    systemctl reload tor
+}
+
 function onion_service_exists {
     onion_service_name="$1"
 
     wait_for_onion_service_base ${onion_service_name}
 
     if [ $(onion_service_exists ${onion_service_name}) == "0" ]; then
-        # reload and try a second time
-        systemctl reload tor
+        # try a second time
+        onion_update
         wait_for_onion_service_base ${onion_service_name}
     fi
 }
         shred -zu /var/lib/tor/hidden_service_${onion_service_name}/*
         rm -rf /var/lib/tor/hidden_service_${onion_service_name}
     fi
-    systemctl reload tor
+    onion_update
 }
 
 function add_onion_service {
         echo "HiddenServicePort ${onion_service_port_from} 127.0.0.1:${onion_service_port_to}" >> /etc/tor/torrc
     fi
 
-    systemctl reload tor
+    onion_update
 
     function_check wait_for_onion_service
     wait_for_onion_service ${onion_service_name}
         echo 'DNSPort 53' >> /etc/tor/torrc
         echo 'AutomapHostsOnResolve 1' >> /etc/tor/torrc
         echo 'AutomapHostsSuffixes .exit,.onion' >> /etc/tor/torrc
-        systemctl reload tor
+        onion_update
     fi
 
     # don't change resolv.conf